[QUESTION] Strange Dialog on Login Screen?

[Milly]

Here's a last-ditch attempt to try and figure this stuff out...

Basically I made myself a login screen for 5.4.8. As of yesterday I thought it was finished. Everything is working 100% perfectly... until I log out from inside the game. Before returning to the character select screen, this happens:



To see all my characters again, I have to press the Okay button. And then it does the normal "Retrieving Character List" dialog before fully loading the screen. This is obviously not normal. And it also has nothing to do with my patch. This is somehow caused by removing the GlueXML check from the client using this Olly Debug method: viewtopic.php?f=26&t=181&hilit=gluexml+check

With or without the mods, this happens every time I remove the check. I've done multiple experiments to confirm this. And the Login Successful dialog is actually just 1 of 2 problems caused by this. The other problem was also an issue with the Character Select screen, but I fixed that one with my own code.

But this one... I can't find a way to fix this.

I use a program that searches my entire GlueXML folder for strings and this Login Successful dialog has no traces whatsoever. It's like a phantom. I hope I'm wrong, but I SWEAR it's not there. I spent at least 8 hours searching for it. Only thing I could find is the "Login Successful" string in GlueStrings.lua, which is called CHAR_LOGIN_SUCCESS, but I can't trace that back to anything in GlueXML. Only place I could find that is in a C++ header file for the SkyFire server. And I tried deleting that line, nothing happened.

So any ideas? Is there a way I could override this with lua? Or is there another more effective way to remove the GlueXML check? Or is the issue entirely serverside? Basically, does anyone have any ideas at all? Because I don't...

[phantomx]

Hey, I just modified my  Wow.exe with 010 for you to try and see if that fixes the problem I turned off all the checks any who let me know.

[Milly]

Hmm, I tried your exe but it crashes instantly with my patch.

[phantomx]

O.o that's very odd... could you post the log for me?

[Milly]

Sure. You mean this thing?

[phantomx]

Yes, I'm going to look it over and see what I find.

Just to be sure you're playing on a 5.4.8 18414 PS right?

[Milly]

I'm on 5.4.8 18414. What's PS mean?

[phantomx]

I'm on 5.4.8 18414. What's PS mean?

Private Server, I think I found the source of the crash going into 010 and checking it out.

Code: [Select]

----------------------------------------
    Memory Dump
----------------------------------------

Code: 32 bytes starting at (EIP = 012B43EA - 10)

012B43DA: 00 00 E8 30  F2 FF FF 5F  8B C6 5E 5B  C3 56 8B F1  ...0..._..^[.V..
* = addr  **                                                  *              
012B43EA: FF 8E 44 1D  00 00 75 0C  E8 8C F1 FF  FF 56 E8 12  ..D...u......V..


Stack: 1024 bytes starting at (ESP = 00A6FE64 - 20)

00A6FE40: 00 00 00 00  00 44 2B 01  34 FD FF FF  E4 02 00 00  .....D+.4.......
00A6FE50: 34 FD FF FF  CC 02 00 00  19 00 00 00  00 00 00 00  4...............
00A6FE60: 00 00 00 00  00 00 00 00  0B 44 2B 01  47 7A 25 01  .........D+.Gz%.
* = addr               **                                         *          
00A6FE60: 00 00 00 00  00 00 00 00  0B 44 2B 01  47 7A 25 01  .........D+.Gz%.
00A6FE70: 80 3B A6 03  54 C9 29 01  00 00 00 00  00 00 00 00  .;..T.).........
00A6FE80: 40 4E 1E 54  B8 0C 70 03  80 3B A6 03  49 0D 70 03  @N.T..p..;..I.p.
00A6FE90: 00 00 00 00  40 4E 1E 54  C4 FE A6 00  01 00 00 00  ....@N.T........
00A6FEA0: B8 FE A6 00  1B CD 29 01  B8 0C 70 03  04 00 00 00  ......)...p.....
00A6FEB0: 00 00 00 00  B8 0C 70 03  D8 FE A6 00  83 B0 29 01  ......p.......).
00A6FEC0: B8 0C 70 03  04 00 00 00  00 00 00 00  B8 0C 70 03  ..p...........p.
00A6FED0: B8 0C 70 03  B8 0C 70 03  F0 FE A6 00  F8 B6 29 01  ..p...p.......).
00A6FEE0: E8 5B 56 00  00 00 00 00  00 00 00 00  01 00 00 00  .[V.............
00A6FEF0: 44 FF A6 00  8D BB 29 01  00 00 00 00  00 00 00 00  D.....).........
00A6FF00: 00 00 00 00  45 6E 67 69  6E 65 20 31  64 33 61 30  ....Engine 1d3a0
00A6FF10: 00 00 00 00  A0 B6 EC 01  01 00 00 00  00 00 00 00  ................
00A6FF20: A0 B6 EC 01  01 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FF30: 5C D2 5F 77  07 EC 4A 75  A4 21 00 00  00 00 00 00  ._w..Ju.!......
00A6FF40: 58 FF A6 00  58 FF A6 00  C2 BB 29 01  00 00 00 00  X...X.....).....
00A6FF50: 4B 8E 25 01  2E EB 25 01  90 FF A6 00  43 CD 92 75  K.%...%.....C..u
00A6FF60: E8 5B 56 00  91 F3 32 A3  00 00 00 00  00 00 00 00  .[V...2.........
00A6FF70: E8 5B 56 00  05 00 00 C0  64 FF A6 00  10 FA A6 00  .[V.....d.......
00A6FF80: 98 FF A6 00  20 7B 93 75  39 76 0B D6  00 00 00 00  .... {.u9v......
00A6FF90: A0 FF A6 00  F9 CC 92 75  FF FF FF FF  66 F6 5F 77  .......u....f._w
00A6FFA0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FFB0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FFC0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FFD0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FFE0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A6FFF0: 00 00 00 00  00 00 00 00  00 00 00 00  00 00 00 00  ................
00A70000: <can't read from this address>

Edit: Oddly enough I can't find this code in 010... I'm not sure what's causing it to crash, what does the error popup window say?

[Milly]

Yeah I'm on a private server. Add me on Skype if you have it.

[Rangorn]

Wow, i have removed glueXML 1 week ago too, and i have this problem too !
There is another problem with logout button and quit button.
I don't know how to desactivate this, i have just renamed it by "Back to character Selection"


I'm very surprised that somebody removed the glueXML on mop too, can you send me a mp that's how you do it ? I can explain my own method too, i said that because the GlueXML on 3.3.5 is a bit different of mop, the JMP SHORT can't reach the "good adress" on mop.

[Milly]

Interesting, I didn't think anyone would have the same issue as me Anyway I just used JMP or JMP LONG for that. And other than that, the method is still the same. Also, I'm sure you've also had the issues with the random crashes then?

[Rangorn]

Really, you can simply replace jmp short by jmp long ? Damn i think that was not possible because you have to add some values.

And  yes i have some weird bug when the server crash or when i lost connexion, black screen with this message.

When i press logout, the game quit with a message "World of Warcraft"
When i press quit button, i'm back to character seletion with the " Login Successful"

I have switched the both function in GameMenuFrameXML :

[spoiler:34p99k2a]

Code: [Select]

<Button name="GameMenuButtonLogout" inherits="GameMenuButtonTemplate" text="LOGOUT">
<Anchors>
<Anchor point="TOP" relativeTo="GameMenuButtonMacros" relativePoint="BOTTOM" x="0" y="-16"/>
</Anchors>
<Scripts>
<OnShow>
if ( not StaticPopup_Visible("CAMP") and not StaticPopup_Visible("QUIT") ) then
self:Enable();
else
self:Disable();
end
</OnShow>
<OnClick>
PlaySound("igMainMenuLogout");
]Quit();
HideUIPanel(GameMenuFrame);
</OnClick>
</Scripts>
</Button>
<Button name="GameMenuButtonQuit" inherits="GameMenuButtonTemplate" text="EXIT_GAME">
<Anchors>
<Anchor point="TOP" relativeTo="GameMenuButtonLogout" relativePoint="BOTTOM" x="0" y="-1"/>
</Anchors>
<Scripts>
<OnShow>
if ( not StaticPopup_Visible("CAMP") and not StaticPopup_Visible("QUIT") ) then
self:Enable();
else
self:Disable();
end
</OnShow>
<OnClick>
PlaySound("igMainMenuQuit");
Logout();
HideUIPanel(GameMenuFrame);
</OnClick>
</Scripts>
</Button>[/spoiler:34p99k2a]


As you can see Logout(); and Quit(); are in the wrong button but it fix this :p


If you want to do that, you have to remove FrameXML, it's exactly the same shit, easier because you just need JMP short, exactly like 3.3.5