This is a read only copy without any forum functionality of the old Modcraft forum.
If there is anything that you would like to have removed, message me on Discord via Kaev#5208.
Big thanks to Alastor for making this copy!

Menu

Author Topic: My Fix Idea for Crashes that come from Editing Blizz ADTs  (Read 2001 times)

PhilipTNG

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 709
    • View Profile
My Fix Idea for Crashes that come from Editing Blizz ADTs
« on: May 29, 2015, 12:26:15 am »
Basically just about anyone who's made an edit on a blizzard ADT with Noggit 1.3 or 1.4 has noticed the eventual crash that happens when you do edits to a blizzard map adt. So I spent half my day changing stuff around until I got around the crash and here's what I came up with.

The crash can happen for multiple reasons, this is a hacky fix idea for one of the crashes that I ran into, it may not work for other people with crashes caused by something else. Also this isn't a recommended fix since I'm pretty sure it could lead to something bad in the long run XD.

[media:2ubkzoww]https://www.youtube.com/watch?v=vdgxYJJLGS8[/media:2ubkzoww]

I'm not giving any type of script out because I have no idea how safe this is and last thing I want is a whole lot of people barking up my inbox filling it with, "You Broke My MAP!!!! WAHHH!!!!"
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

Skarn

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 807
    • View Profile
    • http://skarn-project.net
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #1 on: May 29, 2015, 07:32:42 am »
Haha, you can do it much easier actually even without tinkering with .adt data. As is said for multiple times, the problem is really simple. Blizzard WoWEdit does not really care about the order of textures on adt chunks. So, sometimes there may be 2 or 3 textures on a chunk, and Noggit is not really able to handle groundeffect saving on these adts. So, the best solution is to change Noggit's code. Though, there is a hackfix too. Just pick up a huge brush and paint some random textures with 0 opacity on your change Blizzard adts. Here is another problem. The more adts you fix, the more adts Noggit corrupts around. So, you just fix adts you really need and remove all extra saved ones. That's all.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

PhilipTNG

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 709
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #2 on: May 29, 2015, 08:17:17 am »
Quote from: "Skarn"
Just pick up a huge brush and paint some random textures with 0 opacity on your change Blizzard adts.
I tried that painting idea you posted in another thread, I still ended with the error on the ADT that I errored on in the video. :(
« Last Edit: May 29, 2015, 10:04:01 am by Admin »

schlumpf

  • Administrator
  • Creator of Worlds
  • *****
  • Posts: 2967
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #3 on: May 29, 2015, 08:33:28 am »
I was interested in your idea until I was forced to watch a three minute video. Guess I'll never know the idea.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

PhilipTNG

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 709
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #4 on: May 29, 2015, 08:39:37 am »
Quote from: "schlumpf"
I was interested in your idea until I was forced to watch a three minute video. Guess I'll never know the idea.
it's just zero'ing out the 16 bytes(32x2bit values) at the 0x40 of the MCNK Header, the 16 bytes after the Hole area.  Hacky but avoided the crash that came from editing the file.  Doing so also fixed a buddy's previously un-usable adt files as well which consisted of some 120 adts.

It's probably just something to do with the MCLY but I didn't look too much into it. maybe later I will.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

schlumpf

  • Administrator
  • Creator of Worlds
  • *****
  • Posts: 2967
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #5 on: May 29, 2015, 08:53:19 am »
Zeroing that is not q fix at all, since it breaks detail doodads.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

PhilipTNG

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 709
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #6 on: May 29, 2015, 08:54:59 am »
Quote from: "schlumpf"
Zeroing that is not q fix at all, since it breaks detail doodads.
What are Detail Doodads?  I didn't notice any differences when I did it, perhaps because I was in a low detailed zone maybe?  Would really love it if you could tell me what they are so I can be on the look out for them. ^_^

Thanks!
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

schlumpf

  • Administrator
  • Creator of Worlds
  • *****
  • Posts: 2967
    • View Profile
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

PhilipTNG

  • Contributors
  • Creator of Worlds
  • *****
  • Posts: 709
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #8 on: May 29, 2015, 09:41:50 am »
Quote from: "schlumpf"
Uh.. https://www.youtube.com/watch?v=hk7KVH5NfGM?!
oh, I still have them
Made a Ramp Here,
http://puu.sh/i4yYR.jpg

Clutter still here:
http://puu.sh/i4yZc.jpg

EDIT:


Nevermind, I see what you're saying now.. since the rock tileset has grass on it now when it's not supposed to, and other places, all clutter types spawn in a mashed up fashion. yeah got it. I'll look into it more when I can. Thanks!
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

schlumpf

  • Administrator
  • Creator of Worlds
  • *****
  • Posts: 2967
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #9 on: May 29, 2015, 04:55:35 pm »
That's exactly what that mask is for: to determine the currently-on-top texture.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

kojak488

  • Registred Member
  • Creator of Worlds
  • *****
  • Posts: 351
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #10 on: May 30, 2015, 01:03:18 pm »
Quote from: "schlumpf"
Zeroing that is not q fix at all

The guy with 120 usable (albeit imperfect) ADTs would disagree.  Did it fix the crash?  Yes.  Therefore, it's a fix.  It's an imperfect fix, but still a fix.

I'm sure the guy with all those ADTs is very grateful as he should be.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

schlumpf

  • Administrator
  • Creator of Worlds
  • *****
  • Posts: 2967
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #11 on: May 30, 2015, 01:40:44 pm »
Quote from: "kojak488"
Quote from: "schlumpf"
Zeroing that is not q fix at all

The guy with 120 usable (albeit imperfect) ADTs would disagree.  Did it fix the crash?  Yes.  Therefore, it's a fix.  It's an imperfect fix, but still a fix.

I'm sure the guy with all those ADTs is very grateful as he should be.
Unless you read a post further and realize he now has grass all over the fucking place. There might no longer be a crash, but it certainly fucked up all 120 ADTs. If a fix is inverting the whole intent of the thing broken, it is not a fix.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »

kojak488

  • Registred Member
  • Creator of Worlds
  • *****
  • Posts: 351
    • View Profile
Re: My Fix Idea for Crashes that come from Editing Blizz ADT
« Reply #12 on: May 30, 2015, 03:45:41 pm »
I read all his posts and am aware of the doodad issue.  Hence I said "albeit imperfect".  Perhaps you need to read posts thoroughly?

Quote
If a fix is inverting the whole intent of the thing broken, it is not a fix.

The fix was to stop the crashes.  It stopped the crashes.  Again, it's not a perfect fix, but I don't see you making 120 usable ADTs for the guy.  I'd rather have 120 ADTs with grass all over the place than 120 ADTs that are unusuable at all because you crash all over it.

Are there better ways to accomplish this?  Yes.  Does that mean this doesn't serve a purpose and fix an issue?  No.
« Last Edit: January 01, 1970, 01:00:00 am by Admin »