[QUESTION] Problem with adding a new race. Crashing Worgen.

[Lord_Spaztic]

Alright, I've been a lurker here for a bit and I decided to try adding my own classes and races to a 3.3.5a Wrath Client. So far I've gotten success in The Class Creation, and One Race. (Goblin)

But I'm wanting to add both Worgen and Goblin. So far I've got the Character Create Screen set up correctly. It allows me to actually click on and change to Goblin/New Class Ectra. But every time I click on Worgen, the client crashes with this error:

ERROR #132 (0x85100084) Fatal Exception
Program:   C:World of WorldcraftClient & ServerWorld of WarcraftWow.exe
Exception:   0xC0000005 (ACCESS_VIOLATION) at 0023:004F3C22

The instruction at "0x004F3C22" referenced memory at "0x3D2D8AA8".
The memory could not be "read".

Was going to post links, but because I haven't gotten enough posts I cannot.
Anyhow, I've included in an .rar attachement:
2014-04-28 14.24.13 Crash.dmp
2014-04-28 14.24.13 Crash.txt
CharacterCreate.lua
CharacterCreate.xml
CharacterFacialHairStyles.dbc
CharBaseInfo.dbc
CharHairGeosets.dbc
CharSections.dbc
ChrRaces.dbc
GlueParent.lua
GlueStrings.lua

I'm pretty sure I've added all the correct Hair Geosets, Proper Sections, and Facial Hair Styles. I even started added Race 23 (HU Worgen Gilnean) but finally decided to ask for help.  I'm no pro at reading crash dumps and I've been trying to tackle this issue for the past couple of days. I would really appreciate the help.

[Gurluas]

I have the same issue, also with Worgen.

[Lord_Spaztic]

It's been a few days and I still haven't figured this out.

I've edited every .DBC I can think of that links back to Worgen or that Worgen would point to.
I've changed flags/models in ChrRaces.dbc and no dice. I even made sure the model is working. (Replaced Humane Female with Worgen Female and besides obvious Texture Issues, it shows up.)

I've editted:
ChrRaces, CharBaseInfo, CharFacialHairStyles, CharHairGeoSets, CharSections, CreatureDisplayInfo, CreatureSoundData, SoundEntries, VocalUISound, and BarberShopStyles. =/

The only progress I've made is now the Human Model (stand in for the Worgen Model that crashes when I .morph to it.) it skinned in Worgen .blps when I accidently random onto Worgen DK.
I've even made sure the Background for UI_Worgen is working.

I can provide any file needed or requested if anyone would like to help me out. Or at the very least point me in the right direction. I've read the ERROR #132 thread, but I don't have any Crash numbers that match any of the ones listed.

[stoneharry]

Sounds like the XML button ID does not match the DBC ID (note: the row ID in the DBC is not the ID used for the XML button - the XML buttons are the chronological order of races marked as playable).

[Lord_Spaztic]

Sounds like the XML button ID does not match the DBC ID (note: the row ID in the DBC is not the ID used for the XML button - the XML buttons are the chronological order of races marked as playable).

I'll go through and double check that now. But I'm not 100% sure that's the issue. When I do .morph to a DisplayID of the Worgen Models, my client also crashes with the same error. :S

[stoneharry]

Sounds like the XML button ID does not match the DBC ID (note: the row ID in the DBC is not the ID used for the XML button - the XML buttons are the chronological order of races marked as playable).

I'll go through and double check that now. But I'm not 100% sure that's the issue. When I do .morph to a DisplayID of the Worgen Models, my client also crashes with the same error. :S

Then your creature CreatureDisplayInfo/CreatureModelInfo is broken.

[Gurluas]

What exactly could be the cause of that brokenness?

[Lord_Spaztic]

Still having issues. :/

Brightside; Model is 100% working, ears and all. I can random on Worgen using Reloadui from the Console.

Downside; It crashes when I click off Selected Worgen, or Click on Worgen. Still not 100% sure what you mean about setting the xml button ID to DBC ID. I've tried multiply values, and even tinkered with WORGEN_RACE_ID = in CharacterCreate.lua.

Even Downerside; My server just will not recognize Worgen as a Race. I've made sure to add ChrRace.dbc and Modify the core like I did for Goblins, set MAX_RACES to 13 (from 12) and nope.

But thank you so much Stoneharry for all your current help. I don't think I would have tried CreatureDisplayModel.dbc. >.<

Lua: pastebin.co m/L6kCueHh
XML: pastebin.co m/QbfF1Nwj

[stoneharry]

In your ChrRaces dbc you have the 'Flags' column (2).

This column must specify the 0x8 flag (playable) and NOT specify 0x1 (not playable).

The FactionID (column 3) must be correct.

The BaseLanguage may need to be 1 and NOT 7 in order to be playable.

The MaleModel/FemaleModel needs to point to the correct Display ID / Model ID (I can't remember which).

Each race found chronologically with the flag 0x8 makes it playable. This increments the ID. This means if Worgan has an ID of 20 but is only the 12th race, his ID is 12. The XML button ID points to this ID.

I think the XML button ID is wrong because it is happening when you click it and it tries to map to the DBC. Retrieving it at random from the available races works fine.

[Lord_Spaztic]

That's the problem. :/

http://imgur.com/D21ErpK

I have it all correctly set in the DB. And I made sure I had the XML point to the proper ID.

With WORGEN_RACE_ID line gone, Worgen become                      

Code: [Select]

<CheckButton name="CharacterCreateRaceButton7" inherits="CharacterCreateRaceButtonTemplate" id="7">
<Anchors>
   <Anchor point="TOP" relativePoint="TOP" x="50" y="-61"/>
</Anchors>
</CheckButton>
When it's set to id=7, it crash. 1 = Human, 2 Dwarf, ectra. 12 is somehow Blood Elf.
13+ and it just doesn't switch model/race background and grays out all the Class Icons. :/

[Gurluas]

Considering that this is an entirely new race, and not just enabling an existing one...Perhaps there is one more step that needs to be taken and we're missing it?
From what I can see, everything checks out on my end too in the DBC.

[Lord_Spaztic]

I fixed it, just not the way I wanting. Guessing the Client has a hard limit on character races?

I finally just change Slot 12 from Fel Orcs to Worgen, changed all the other DBC Files and it worked.

[Gurluas]

Yeah but that's not a solution which is acceptable to me. We need to find out how to properly add new races and what causes these crashes.

Not to mention...That method screws up NPCs. I.E all Fel orcs will now be Worgen.

For instance, what makes the Lua recognize things such as TROLL_RACE_ID.
This stuff must be stored somewhere, and that's where we have to add an additional line for the new races. Another observation I had, is that I was unable to add flavor text for Worgen, it was ignored ingame.

To make an example..

The game recognizes this line:
ABILITY_INFO_FORESTTROLL1 = "- Berserk, increasing attack and casting speed.";

But not this:
ABILITY_INFO_WORGEN1 = "- Roar.";

It's as if the information pertaining all the original 21 races are stored somewhere.
We need to figure out where, so that we can add the new races we want to add.

[Lord_Spaztic]

Yeah but that's not a solution which is acceptable to me. We need to find out how to properly add new races and what causes these crashes.

Not to mention...That method screws up NPCs. I.E all Fel orcs will now be Worgen.

For instance, what makes the Lua recognize things such as TROLL_RACE_ID.
This stuff must be stored somewhere, and that's where we have to add an additional line for the new races. Another observation I had, is that I was unable to add flavor text for Worgen, it was ignored ingame.

To make an example..

The game recognizes this line:
ABILITY_INFO_FORESTTROLL1 = "- Berserk, increasing attack and casting speed.";

But not this:
ABILITY_INFO_WORGEN1 = "- Roar.";

It's as if the information pertaining all the original 21 races are stored somewhere.
We need to figure out where, so that we can add the new races we want to add.

That was what I was trying to imply with the Hard Limit. It might actually be built into the client. Kinda like MAX_RACES in the Emu's that you have to increase the number of.

Secondly. Just changing Fel Orcs's Race didn't screw up anything. - NPCs use a pre-baked texture and you're not model swapping. You're editting a DBC file so that you can make the "Felorc Race" use Worgen Male/Female Model IDs.  http://imgur.com/a/uOK3p

And I strongly believe it's a hard coded limit in the client. I just changed everything from 22 to 12 in Race Related DBCs/Server and I have everything besides Languages/Barber working perfectly. I've even looked at EoC's DBC files, and Heroes-WoW's custom DBC files. So far I haven't seen any of them add rows that worked, just modified old rows.

I've also didn't have  issue with Gluestrings.lua and showing Worgen related strings. I just copied a MoP version and dropped it. Kinda hackish, but I can go back and fix older races racial strings. It worked before I switched Worgen to Felorc (When I random'd on Worgen) and it still works now.

Code: [Select]

ABILITY_INFO_WORGEN1 = "- Can periodically move quickly.";
ABILITY_INFO_WORGEN2 = "- Critical chance increased.";
ABILITY_INFO_WORGEN3 = "- Resistant to Nature and Shadow damage.";
ABILITY_INFO_WORGEN4 = "- Skinning skill and speed increased.";

[Gurluas]

If it's in the client then we need to identify it so we can raise it.
I'd much rather add new races, and no it does mess up npcs.
All Fel Orc npcs are set to use that specific race (12) Meaning they'd all become Worgen with Fel orc skins unless you make a shabby workaround similar to the old "goblin_old" system they used for Cata Goblins before the discovery of the Cata creaturedisplayinfoextra.

Raising the real limit is the best solution.
The question is though...Is this limit within the client? Or is it hidden in some lua somewhere?