Modcraft - The community dedicated to quality WoW modding!

Wrath of the Lich King Modding => Serverside Modding => Topic started by: Big Bad Bot on May 29, 2016, 07:18:14 pm

Title: Trinity WLK - Limits on Factions?
Post by: Big Bad Bot on May 29, 2016, 07:18:14 pm
Hello everyone. I need to create a lot of new factions (like 60 new ones) without delete the old ones. I haven't any issue creating the first ten editing Faction.dbc and FactionTemplate.dbc but after the IDs 1170 and 1192 of the first DBC and 2245 and 2267 from the second one, the server start to crash.

Do you know if there's a limit of factions?
it's possible to "break" this limit messing with the core or adding more entries in a SQL table?]


PS: All the factions are the same with a few fields changed.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Ascathos on May 30, 2016, 12:44:02 am
Be more specific about the crash. Best attach a crash log with debug.
Title:
Post by: Big Bad Bot on May 30, 2016, 04:52:20 am
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   worldserver.exe
  Application Version:   0.0.0.0
  Application Timestamp:   4e0950f4
  Fault Module Name:   worldserver.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   4e0950f4
  Exception Code:   c0000005
  Exception Offset:   0000d9cd
  OS Version:   6.1.7601.2.1.0.272.7
  Locale ID:   1033
  Additional Information 1:   0cd4
  Additional Information 2:   0cd433d4615af718ba90b11f461dad53
  Additional Information 3:   9489
  Additional Information 4:   94892a3496359438aa9a1235c0486e79

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid= ... cid=0x0409 (http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409" onclick="window.open(this.href);return false;)

If the online privacy statement is not available, please read our privacy statement offline:
  C:Windowssystem32en-USerofflps.txt
Title: Re: Trinity WLK - Limits on Factions?
Post by: Makpptfox on May 30, 2016, 08:33:35 am
I had to change factions and had a crash when I reached a certain numbers of new custom faction.
I can't help you more than that, but I'm pretty sure there is a limitation.

(You can try to changes the factions with OLD or UNUSED tag on it btw, that's how I've tricked the limitation.)
Title: Re: Trinity WLK - Limits on Factions?
Post by: Ascathos on May 30, 2016, 09:03:16 am
There is a file in your ServerCrashlog folder. It's a .txt file.

Can you upload it's content to a pastebin and post it here ?
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on May 30, 2016, 09:35:46 am
Are you guys really sure that you have done everything correctly? Those numbers which you have taken as IDs are pretty low, I quite doubt thats something what would be able to cause crashes. I have also habit of starting everything from higher number, my custom factions are 3200+, so your assumption is most likely incorrect.

Show me some examples of your data in your DBCs.
Title: Re: Trinity WLK - Limits on Factions?
Post by: schlumpf on May 30, 2016, 09:45:49 am
Factions are used in bitmasks, so there suddenly being some 2^n/8 wouldn't be too surprising.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Scytheria23 on May 30, 2016, 09:57:34 am
I had the exact same problem myself (first dozen or so new factions worked fine, then POP!).  In the end I just reused the redundant ones.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on May 30, 2016, 10:18:07 am
Quote from: "schlumpf"
Factions are used in bitmasks, so there suddenly being some 2^n/8 wouldn't be too surprising.
Reputations. Not factions. Thats why I want to see their DBCs. 256 is still much more than WotLK uses, and he spoke only about 60 custom ones. So if max isn't 128 (meh, signed again???), its still quite strange issue.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Big Bad Bot on May 30, 2016, 11:15:36 am
Quote from: "Scytheria23"
I had the exact same problem myself (first dozen or so new factions worked fine, then POP!).  In the end I just reused the redundant ones.

I tried it once replacing the CTF - Flag - Horde 2 reputation (ID=1160) and doesn't work, but puttin the exact same one on ID 1164 works without issues -but I have other custom faction I need in that ID-

Quote from: "Ascathos"
There is a file in your ServerCrashlog folder. It's a .txt file.

Can you upload it's content to a pastebin and post it here ?


I don't have the option to save crashlogs active, the last one was from 2014 LOL. Con you tell me how to turn it on?
Title: Re: Trinity WLK - Limits on Factions?
Post by: Ascathos on May 30, 2016, 11:25:05 am
Quote from: "Big Bad Bot"
Quote from: "Scytheria23"
I had the exact same problem myself (first dozen or so new factions worked fine, then POP!).  In the end I just reused the redundant ones.

I tried it once replacing the CTF - Flag - Horde 2 reputation (ID=1160) and doesn't work, but puttin the exact same one on ID 1164 works without issues -but I have other custom faction I need in that ID-

Quote from: "Ascathos"
There is a file in your ServerCrashlog folder. It's a .txt file.

Can you upload it's content to a pastebin and post it here ?


I don't have the option to save crashlogs active, the last one was from 2014 LOL. Con you tell me how to turn it on?
Crashlogs are ALWAYS generated if worldserver crashes. The only useful ones are from Debug, though. RelWithDebug is "meh", but might be a pointer already.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Steff on May 30, 2016, 01:42:17 pm
If not and you use a repack there are options for logs in the config file(s).
Perhaps they are turned of.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Big Bad Bot on May 30, 2016, 11:32:55 pm
For some kind of strange reason, I found the new crash logs! I think I was totally sleepy when I see the folder the first time  :|

Crashes/Worldserver.exe

Quote
Revision: TrinityCore Rev: 0 Release Hash: Archive (Win32, little-endian)
Date 30:5:2016. Time 2:49
//=====================================================

*** Operation System ***
Windows Vista or Windows Server 2008 Server 4.0 Service Pack 1 (Version 6.1, Build 7601)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on May 31, 2016, 08:55:01 am
Nah, can you just show me screenshot of your faction.dbc custom entries?
Title: Re: Trinity WLK - Limits on Factions?
Post by: Big Bad Bot on May 31, 2016, 12:24:45 pm
Here's the two versions: The one wich works having a few new factions and the one with one line more wich doesn't work:
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on May 31, 2016, 02:32:19 pm
OK, that confirms my and schlumpfs theory, sadly, its even worse than I feared. Value in row #2, reputationIndex, has apparently max value 2^7-1 (127). This index is used in at least one bit mask, so its max range in reality probably can't be changed at all. If DBC with 128 index causes crashes, here you go, 128 is too high value for system.

So you will most likely need to overwrite some old and for you useless reputation indexes.
Title: Re: Trinity WLK - Limits on Factions?
Post by: Big Bad Bot on May 31, 2016, 04:32:17 pm
You're right. I try to add more lines in the faction.dbc but now with the -1 value in that field and works perfectly. It isn't what I looking for, but is totally usefull; from 104 to 127 it's possibly to create factions without delete or overwrite anything, so is 23 factions for free!
Title: Re: Trinity WLK - Limits on Factions?
Post by: Kaev on May 31, 2016, 09:34:13 pm
That would be a cool information in the wowdev wiki, if it isn't already there! :)
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on June 01, 2016, 09:49:14 am
I have added it there immediately.
Title: Re: Trinity WLK - Limits on Factions?
Post by: calabasa3 on July 30, 2016, 06:57:51 am
BUT, WHAT IS THE ESPECIFIC SOLUTION?
I WANNA INSERT MORE THAN 60 FACTIONS DIFERENTS.
:/
Title: Re: Trinity WLK - Limits on Factions?
Post by: Amaroth on July 30, 2016, 10:50:10 am
That caps lock...

You can have up to 127 factions you can obtain reputation with. Every single one must have unique reputationIndex in faction.dbc. You can set reputationIndex of some blizzlike faction to -1 and use it for your custom faction, that should work, at least for most of factions.

If you want to increase that limit of 127, you would need to change database, core and would have to really hope that you would not need to also change something what is hardcoded in client. So changing that limit itself is very unlikely.