[SOLVED] Improved Starfire help?

[The0dark0one]

I am working with a classic vanilla 1.12.1 Mangos Zero server.  I moved some talents and spells around on the classes.  I moved Starfire and the talent Improved Starfire to a mage.  Upon doing this, it apparently broke the function of Improved Starfire.  The stun works but it no longer reduces cast time as it is supposed to.  I have narrowed down the reason that it is not working to columns 104-106 in Spell.dbc titled EffectItemType.

I compared Improved Starfire with Improved Frostbolt.
I found that both have Effect 6, which is Apply Aura.  
In EffectApplyAuraName, they both apply aura #107 which is Add Flat Modifier.  
In EffectMiscValue, they both have a value of 10 which indicates that the modifier is SPELLMOD_CASTING_TIME.

This is where I get lost because they never refer to which spell receives the cast time modification.

The one area they both differ in is EffectItemType.
Improved Starfire has EffectItemType 0x4
Improved Frostbolt has EffectItemType 0x20

I believe that this somehow refers to what spells are affected by these talents, but I've no idea how.

Any ideas?

[kojak488]

I have narrowed down the reason that it is not working to columns 104-106 in Spell.dbc titled EffectItemType....

The one area they both differ in is EffectItemType.

Here's a hint: those statements of yours are incorrect.

[The0dark0one]

I have narrowed down the reason that it is not working to columns 104-106 in Spell.dbc titled EffectItemType....

The one area they both differ in is EffectItemType.

Here's a hint: those statements of yours are incorrect.

Ah damn, which columns of importance did I miss?

[kojak488]

Ah damn, which columns of importance did I miss?

Rather than ask that question you should be going back to the spell.dbc and comparing the two spells for other fields that are different.  You may not know what those other fields do yet, but that's part of the process (i.e., learning to understand the spell.dbc).  That's all the information I'm willing to share.  If I were simply going to tell you the column, then I would've done so in my first post.

[The0dark0one]

Ah damn, which columns of importance did I miss?

Rather than ask that question you should be going back to the spell.dbc and comparing the two spells for other fields that are different.  You may not know what those other fields do yet, but that's part of the process (i.e., learning to understand the spell.dbc).  That's all the information I'm willing to share.  If I were simply going to tell you the column, then I would've done so in my first post.

I've done this process three times already.  I've even scoured the source code searching for references to these spells and these spell effects.  I've figured out so many other spells lately but these types of spells have been quite difficult to figure out.

Here are the other differences except for Improved Starfire's references to its stun effect:

Code: [Select]

Starfire Frostbolt
ProcFlags   0x15550 0x0
ProcChance  3 101
SpellLevel  0 1
EquippedItemSubClass 0x0  0xFFFFFFFF
EffectItemType 0x4  0x20
SpellIconID 1485 188
SpellPriority  0 50
SpellFamilyName 7 3
StanceBarOrder 0 -1
DmgMultiplier3 0 1
These all seem useless to me except for perhaps EffectItemType, SpellFamilyName, and SpellPriority.  I'm going to search the regular spells frostbolt and starfire to see if they reference these talent spells.

EDIT: Turns out after 5 days of researching this, it was working all along.  I hand measured the cast times of the spells and found that it was all working appropriately.  The problem was that the tooltip was not updating but the actual cast time was.  Anyone have any idea why the tooltip is updating for the correct classes but not after I move the spell to a different class?