Blizzard Installer Customisation

[schlumpf]

Note that Z_BUF_ERROR is not fatal,

It just means, that either there is no more output or no more input. Either, it is perfectly fine and inflated everything or the input is incomplete. As output begins with 'MZ', the output is also likely to be correct.

[schlumpf]

And given, that not Z_STREAM_END is returned, it is likely that the input has stopped too early.

[stoneharry]

Well, if I trace your code through showing only the lines of code executed:

Code: [Select]

int inflateResult = inflate (&stream, 4);
...
inflateEnd (&stream);
...
return -3;

-> returned

if (res || inflated != output->size())
{
  throw std::runtime_error ("error: not inflated correctly");
}
So, if your saying it should still have worked, shall I change the code so that it continues?

edit:

I assume it should be doing this:

Code: [Select]

   if (inflateResult == 1)
    {
      *written_output = stream.total_out;
      return inflateEnd (&stream);
    }
Where, ideally 1 is returned (success?) so the written_output then gets a value (inflated), otherwise inflated will not match the output size.

[schlumpf]

Try writing output to disk and look at it. Also, try increasing input size read from BsnI. I'd wonder if, but it may be wrong.
The last possibly wrong thing is the size of unsigned int being wrong, but I really can't believe that.

[stoneharry]

Try writing output to disk and look at it. Also, try increasing input size read from BsnI. I'd wonder if, but it may be wrong.
The last possibly wrong thing is the size of unsigned int being wrong, but I really can't believe that.

Well I modified all the error handling so that it writes it, and it resulted in three files being output:

Installer.exe
RichEd20.dll
Unicows.dll

Which looks correct to me. o_0

[schlumpf]

The filenames of course are fine. The question is if the contents are..

[stoneharry]

The filenames of course are fine. The question is if the contents are..

Apparently not:

[stoneharry]

try increasing input size read from BsnI.

Where is this done?

[schlumpf]

The only thing I'd suspect being wrong is the compression mode / strength chosen for inflate. But as you know, I successfully extracted your installer using exactly that source code.

May you give sizeof(BsnI_Entry) (or whatever it was called)?

[stoneharry]

The only thing I'd suspect being wrong is the compression mode / strength chosen for inflate. But as you know, I successfully extracted your installer using exactly that source code.

May you give sizeof(BsnI_Entry) (or whatever it was called)?

sizeof(BsnI); returns 16.
sizeof(BsnI_entry); returns 76.

[schlumpf]

Those values are fine.

I have no idea what might be wrong, then. It should work fine.

Try different numbers for inflate, try using bsnientry.data_size * 2.

[stoneharry]

Those values are fine.

I have no idea what might be wrong, then. It should work fine.

Try different numbers for inflate, try using bsnientry.data_size * 2.

When I did that, the returned result from inflation was 1 rather than -5, which signals a success.

However, when assembling using those output files, it still does not work. The file size was larger.

[schlumpf]

Why try assembling them? The exe is a executable itself and should be possible to run.

[stoneharry]

Why try assembling them? The exe is a executable itself and should be possible to run.

Ah, didn't realise this. However, the extraction must still not be correct because:

[schlumpf]

Use 1.2.3. I guess other versions than their own won't get proper results.